openwall / openwall/john

Add Controlize rules

Open
#4,133 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
C
Stars
13.6k
Forks
2.6k
PR merge metrics
No merged PRs in 30d

Description

I think we need a pre-defined ruleset called Controlize, e.g.:

[List.Rules:Controlize]
s[aAbB]\p\r[\x01\x01\x02\x02] Q

And so on for other letters, and perhaps listing more characters per line. I was just lazy here.

We should also consider rules for other ways to "controlize" - e.g., of only some (not all) instances of a character, or of multiple different characters at once. Maybe we should add some rule commands into JtR itself to do this efficiently. This is similar to case toggling.

Maybe we should skip producing '\n' for now, as it would break the john.pot file format until we finally implement hex-encoding there (#2354).

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the existing case-toggling rules and the proposed Controlize syntax in this issue. Clarify whether the work is limited to a predefined ruleset or also includes new rule commands and partial or multi-character controlization. Check the john.pot limitation and issue #2354 before defining what done means.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
security
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.