openwall / openwall/john

salted plaintext format or generic format tracer for debugging

Open
#4,113 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C
Stars
13.6k
Forks
2.6k
PR merge metrics
No merged PRs in 30d

Description

There is plaintext format ($0$) that prints arguments of set_key() with --verbosity=6. I think a salted variant would be helpful to understand single mode better. I guess set_salt() and maybe crypt_all() should be reported too.

Additionally I think it would be nice to print fork's id for the call as in status line with --fork= option. Same applies to current plaintext format.

Maybe output of candidates should be quoted to allow accurate capturing of candidates by scripts.

Maybe a separate format is a wrong way. It may be better to implement generic way to trace calls at the interface of any format. This way it would be easier to replicate environment implied by certain format. An option to skip real crypt_all() may be added for speed.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by examining the existing plaintext format ($0$) and the interface calls named in the issue: set_key(), set_salt(), and crypt_all(), including their --verbosity=6 output. Compare this with the fork ID shown by --fork= and candidate output handling. Done should mean a decided scope for generic tracing or a salted format, with the requested fork, quoting, and optional crypt_all() behavior addressed.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
cli, devtools
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.