openwall / openwall/john

Drop the separate WPAPSK PMK formats

Open
#4,103 0 comments 0 reactions 1 assignee View on GitHub

@magnumripper is already working on this.

Since Sep 21, 2019.

maintenance/cleanup
Dominant language
C
Stars
13.6k
Forks
2.6k
PR merge metrics
No merged PRs in 30d

Description

We should move the PMK functionality into the main formats. It's simple: If key length is <64, it's a passphrase. If it's 64 it's supposed to be hex and is a 256-bit PMK. Speed isn't important as you can't brute force a key anyway, it's more for testing lists of keys, null keys and things like that. Besides, the current WPAPSK-PMK OpenCL format doesn't feature internal mask anyway (it would be a lot faster but it would still be friggin' impossible to brute-force a key).

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.