openwall / openwall/john

Allow "single mode" rules with "phrases" wordlist

Open
#4,015 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
C
Stars
13.6k
Forks
2.6k
PR merge metrics
No merged PRs in 30d

Description

If a wordlist (or other source of candidates) contains entries like "my password" or "sunny beach", we should optionally be able to use them with "single mode" rules (pass -p rejection flag, have 1 and 2 refer to the words and + to concatenate).

We could even have that option specify the separator, as in --phrase-delimiter=" " or --phrase-delimiter=:.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the single-mode rule handling and the wordlist or candidate-source parsing. Trace how the -p flag, numeric word references, and + concatenation currently work; done means phrase entries can be used with an optional separator such as a space or colon without breaking existing single-mode behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
cli, security
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.