openwall / openwall/john

Add new option --fork-unless-omp=N

Open
#3,989 5 comments 0 reactions 1 assignee View on GitHub

@magnumripper is already working on this.

Since May 21, 2019.

enhancement
Dominant language
C
Stars
13.6k
Forks
2.6k
PR merge metrics
No merged PRs in 30d

Description

I was running a script that extracted hashes, evaluated all formats (using --show=formats) and ran john once per format. So this hit me:

The new option --fork-unless-omp[=N] will be a no-op if the selected format has OpenMP support. But if not, it will imply --fork=N (if N was supplied) or --fork=C otherwise (with C being the answer from omp_get_max_threads() if available - if it's not available, N will be a mandatory option as in --fork-unless-omp=N (and shown as such with -h).

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.