openwall / openwall/john

locale problem: question marks instead of "No such file or directory" error message

Open
#3,719 6 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C
Stars
13.6k
Forks
2.6k
PR merge metrics
No merged PRs in 30d

Description

$ echo $LANG
ru_RU.UTF-8

$ LANG=C john --restore=asdf
fopen: asdf.rec: No such file or directory

$ john --restore=asdf
fopen: asdf.rec: ??? ?????? ????? ??? ????????
cat: bbasdf.rec: Нет такого файла или каталога
$ cat bbasdf.rec # reordered to show match

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue with LANG=C and LANG=ru_RU.UTF-8 using the shown john --restore=asdf and cat commands, then compare the two error outputs. Trace the error-message localization path and identify what must change so the Russian message is rendered as text rather than question marks; done when the localized output is readable and matches the related cat message.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
cli, localization
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.