Enhance gpg2john user experience
@kholia is already working on this.
Since Mar 25, 2019.
- Dominant language
- C
- Stars
- 13.6k
- Forks
- 2.6k
- PR merge metrics
- No merged PRs in 30d
Description
As I wrote in https://www.openwall.com/lists/john-users/2019/03/25/14:
-
I had to insert an empty line after the "Version: " line. Maybe we shouldn't require that empty line, especially if PGPfreeware produces output without that empty line?
-
Having both a private and a public key in the file made gpg2john refuse to process the file. I had to delete the public key from there, even though I initially tried putting both in there. Maybe we should have gpg2john silently skip the public key(s), or in general skip (but mention on stderr?) whatever it can't recognize?
-
gpg2john outputs an empty line and "File ..." to stderr. I doubt this serves a purpose, and IIRC is inconsistent with our other *2john tools. Maybe we should drop that.
I checked past issues, and found some related ones (e.g. #2783 #2805), but none covering the specific 3 items above.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.