openwall / openwall/john

Protect the terminal from control characters

Open
#3,645 5 comments 0 reactions 2 assignees View on GitHub

@jfoug is already working on this.

Since Feb 14, 2019.

enhancement
Dominant language
C
Stars
13.6k
Forks
2.6k
PR merge metrics
No merged PRs in 30d

Description

We've added a non-invasive but also rather ineffective safeguard in #3641. As discussed in comments on that PR, we need to actually guard the terminal against control characters embedded in login names, candidate passwords, and cracked passwords.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.