openwall / openwall/john

Decouple endianity changing and memory debug dumping from memory.[ch]

Open
#3,537 2 comments 0 reactions 1 assignee View on GitHub

@jfoug is already working on this.

Since Dec 19, 2018.

maintenance/cleanup
Dominant language
C
Stars
13.6k
Forks
2.6k
PR merge metrics
No merged PRs in 30d

Description

As discussed in #3532 Write separate plug files to decouple the endianity modification functions, and the memory dumping functions. This way, memory.[ch] will be VERY close to the master branch.

Within memory.h, there will be 2 includes added, which make sure that all definitions are exactly the same as today, when some code includes memory.h, even though the definitions no longer exist within that file.

Once 3532 is merged, I will start on this one. It should be pretty trivial

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.