openwall / openwall/john

Formats written as salt-only even though they could be normal.

Open
#3,437 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
C
Stars
13.6k
Forks
2.6k
PR merge metrics
No merged PRs in 30d

Description

The list below can likely grow a lot if we review all Dhiru's formats. I'm not sure we need to fix them at all? A drawback with doing so is it increases OpenCL result transfer size.

  • CloudKeychain has a 32-byte binary
  • Telegram has a 16-byte binary

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the CloudKeychain and Telegram format implementations and how their binary values are represented in OpenCL result handling. Determine whether each can use a normal format without an unacceptable increase in result-transfer size; done requires a maintainer decision and corresponding format changes or a documented reason to leave them salt-only.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
cryptography, security
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.