openwall / openwall/john

Review use of strncpy / strncat and the like

Open
#3,339 24 comments 0 reactions 3 assignees View on GitHub

@jfoug is already working on this.

Since Dec 31, 2018.

bug maintenance/cleanup
Dominant language
C
Stars
13.6k
Forks
2.6k
PR merge metrics
No merged PRs in 30d

Description

For example:

  • strncpy that can be replaced with strnzcpy
  • Drop redundant memsets before or after strncpy
  • Perhaps write our own version of strncat

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.