Allow --cost for --list=format-tests
Open
Nobody has claimed this yet.
enhancement
- Dominant language
- C
- Stars
- 13.6k
- Forks
- 2.6k
- PR merge metrics
- No merged PRs in 30d
Description
It would be nice to filter the format tests in --list=format-tests with --cost=...,
e.g.
./john --list=format-tests --format=ssh --cost=1:1
Of course, the --cost addition doesn't make sense for formats which support no tunable costs (or fewer tunable costs than specified with --cost=).
I suggest those formats just print an error message to stderr and don't report any tests.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the john --list=format-tests command path and trace the existing --cost option handling. Check how format tests are selected and how unsupported cost parameters are reported. Done means matching tests are listed for supported tunable costs, while incompatible formats report an error on stderr and list no tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- cli
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100