openwall / openwall/john

SIMD enable on some formats building under BE

Open
#2,922 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
C
Stars
13.6k
Forks
2.6k
PR merge metrics
No merged PRs in 30d

Description

The prior BE porting project 'skipped' some formats. These simply have the SIMD disabled when building under a BE SIMD machine. This bug is to re-enable the SIMD logic so it works in these formats. NOTE, some of these are NOT trivial when it comes to SIMD usage, lol. Dynamic format is handled all in a separate bug #2892, but is 100% related to this one. But that beast is very ugly, and should be done with its own PR, since there will likely be hundreds of porting points in the code.

  • hdaa
  • sapb
  • sapg
  • saph (and utf8)
  • SunMD5
  • wpapsk
  • 7z (and utf8)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The remaining unchecked formats are SunMD5 and 7z, including utf8 for 7z; begin by reviewing their existing big-endian SIMD handling and the prior BE porting work. Done means the SIMD logic is re-enabled and works when building these formats on a big-endian SIMD machine, while dynamic format remains in issue #2892.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
performance
Issue type
Bug
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.