openwall / openwall/john

Unification and Common helper code for SIMD usage in formats

Open
#2,915 17 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

maintenance/cleanup
Dominant language
C
Stars
13.6k
Forks
2.6k
PR merge metrics
No merged PRs in 30d

Description

Lets first talk about what we think we can do. How easy each task is, and just how it can be done.

  • GETPOS (and other macros) unification into 1 or 2 header files
  • set_key common code (even if just common 'parts' are done with macros or inlines
  • update fmt_default_* methods ?? not sure here.
  • possbile common code for split possible case unification, and may handle 'tags', etc
  • cmp_[all][one] commonality. Possibly even cmp_exact for some formats.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the existing SIMD format implementations and the checked and unchecked tasks listed in this issue. Confirm the intended scope with maintainers before changing code; done means the agreed common handling for the remaining format helpers is implemented without leaving the proposed areas ambiguous.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
performance
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
15/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.