openwall / openwall/john

Source tree clean-up / reorganize

Open
#2,789 5 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

RFC / discussion
Dominant language
C
Stars
13.6k
Forks
2.6k
PR merge metrics
No merged PRs in 30d

Description

It was brought up recently in a mail discussion that our source tree is "disorganized" with like "800 source files in a single directory". This is absolutely true. I'm so used to it I haven't cared much about it. Making it better should be pretty easy. Here are two easy steps for making it a little better:

  1. For a starter, we could move all plugins (and nothing else) to src/plugins. That will half the number of files directly under src...
  2. We have lots of pure OpenCL headers (for inclusion by kernels) directly under src, they should either go to src/opencl like the kernels - or perhaps src/opencl/include if we want to.

After that, it gets trickier to get lots of improvement with little work but we can probably find out a couple more things.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by inventorying the files directly under src and identifying the plugins and pure OpenCL headers mentioned in the issue. Move plugins to src/plugins and place the OpenCL headers under src/opencl or src/opencl/include; done means the source tree is reorganized without breaking the project.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
tooling
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.