openwall / openwall/john

Merge Johnny the GUI into the jumbo tree & build

Open
#2,673 6 comments 1 reaction 1 assignee View on GitHub

@shinnok is already working on this.

Since Apr 10, 2020.

maintenance/cleanup
Dominant language
C
Stars
13.6k
Forks
2.6k
PR merge metrics
No merged PRs in 30d

Description

I think Johnny the GUI will receive more attention from both (prospective) maintainers/developers and users if we merge it into jumbo. Have it as a configure option (maybe enabled by default, but skipping gracefully when not all required libraries are installed?) and have it built last (after all of the command-line tools have been built, so that a Johnny build failure wouldn't prevent access to any of the existing functionality of jumbo). This will also ensure that a user gets a compatible combination of versions of jumbo's command-line tools and Johnny (as long as we do maintain it).

To make it clear: the only merge I am proposing here is of the source trees and build procedures - have both projects combined into the same ./configure && make. Not any merge of the source code beyond the build scripts, etc. In fact, Johnny's source code should mostly remain in its own subdirectory in the merged tree (perhaps src/johnny or src/gui).

If there are no objections, then who's to work on it? Maybe @shinnok and/or @math07? :-)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.