openwall / openwall/john

Consider changing algorithm_name on the fly

Open
#2,567 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
C
Stars
13.6k
Forks
2.6k
PR merge metrics
No merged PRs in 30d

Description

In https://github.com/magnumripper/JohnTheRipper/pull/2525#issuecomment-298842256 @solardiz wrote:

On Wed, May 03, 2017 at 12:32:17AM -0700, magnum wrote:

Depending on salt type, we either do SHA-256 (with AVX2) or scrypt (without), so no matter how we put it this algo string will be ambiguous. Same problem with many other formats.

Maybe include "... or ..." in the algorithm string?

(When all loaded salts are of the same type, we could also patch the string at runtime to be specific, but that's tricky and probably not worth the bother. We could even patch the "or" to "and" when we know that we have salts of both types, but that's similarly tricky, especially if we want to consider only the uncracked hashes.)

I will look into this at some point. It's quite confusing loading eg. only Office 2007 hashes and getting the output Office, 2007/2010/2013 [SHA1 128/128 AVX 4x / SHA512 128/128 AVX 2x AES].

A change of algo name could be made in eg. reset() (which has knowledge about the loaded db) provided that would cut it for core. And of course some minor core changes could be made if needed.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading reset() and the core handling of algorithm names, then reproduce the Office 2007 output described in the issue with only one loaded hash type. Determine how loaded salt types, including uncracked hashes, should affect the displayed name; done means the name is specific when possible and remains correct for mixed types.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
security
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.