openwall / openwall/john

Setup automated Windows builds/CI using Cygwin on ReactOS

Open
#2,543 38 comments 0 reactions 1 assignee View on GitHub

@kholia is already working on this.

Since Jan 22, 2018.

testing
Dominant language
C
Stars
13.6k
Forks
2.6k
PR merge metrics
No merged PRs in 30d

Description

I suggested this before in https://github.com/magnumripper/JohnTheRipper/issues/2372#issuecomment-270007448 but at the time I thought that ReactOS wouldn't run Cygwin.

It appears that since mid-2016 ReactOS is finally able to run Cygwin:

https://twitter.com/reactos/status/735141249775194112
https://jira.reactos.org/browse/CORE-7739

so maybe we should proceed with that setup, in a VM. Or maybe two setups: 32-bit and 64-bit.

Also relevant is this comment from the above ReactOS JIRA entry:

Carlo Bramini added a comment - 2016-12-08 12:35

I think it would be worth to remind that CYGWIN does not support anymore XP/2003.
Last version expected to work is 2.5.2, but keep in mind that it is not binary compatible with recent packages, so replacing just cygwin1.dll won't work.

Since we probably still want our JtR builds to work on XP/2003, perhaps we should stick to Cygwin <=2.5.2.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.