openwall / openwall/john

Audit ARCH_WORD in jumbo.

Open
#2,364 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

maintenance/cleanup
Dominant language
C
Stars
13.6k
Forks
2.6k
PR merge metrics
No merged PRs in 30d

Description

https://github.com/magnumripper/JohnTheRipper/commit/a54420a5ab7f6b85aeb23e2547dbcd163f2467a1#commitcomment-20192177

Remove things which do not 'need' native machine size for performance. Use uint32_t or uint64_t if there are certain areas which require a specific size.

Alignment usage may need to be looked at for speed for data which actually is handled as 4 byte words. Many places use ARCH_WORD for alignment. We need to see if there is any benefit or not (I bet not). also, going to uint32_t in this cases will save memory space (not huge, but some).

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing ARCH_WORD uses throughout jumbo and the linked commit discussion. Identify uses that do not require native machine size, replace them with appropriately sized integer types where justified, and assess whether ARCH_WORD-based alignment is beneficial; done when the audit is complete and the relevant size and alignment choices are validated.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
performance
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.