openwall / openwall/john

Autodetect more OpenSSL installation paths (for Mac OS X)

Open
#2,347 6 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

portability
Dominant language
C
Stars
13.6k
Forks
2.6k
PR merge metrics
No merged PRs in 30d

Description

As summarized in http://www.openwall.com/lists/john-users/2016/08/04/3 recent Mac OS X now needs its OpenSSL installed by weird means, and it gets installed in weird places. This makes it tricky to build JtR jumbo. Let's enhance our configure.ac to check for OpenSSL headers and libraries in those directories by default, much like it already does check for headers in /usr/local/ssl now. (We were just reported, privately, of a failed build attempt on Mac OS X where ./configure finds the headers, but not the libraries. I don't know how exactly this happened, but I expect issues and reports of this sort to be frequent unless we look for both of these things in multiple directories that various Mac OS X tools install into by default.)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in configure.ac and inspect how the existing /usr/local/ssl header check works, including how library detection is handled. Identify the additional Mac OS X installation locations implied by the issue, then verify with ./configure that OpenSSL headers and libraries are both found there. Done means the reported Mac OS X build path is detected by default.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
build-system
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.