openwall / openwall/john

Use restore_tester_fmt.c to find and correct restore issues

Open
#2,082 71 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

core branch non-trivial testing
Dominant language
C
Stars
13.6k
Forks
2.6k
PR merge metrics
No merged PRs in 30d

Description

Things I know about. Add more as they are seen/fixed, since some of these should get done in core also.

Some of these could be handled as 'hybrid' type blocks added to the end of a .rec file (I think). Things like the rules and multi-salts redoing work, could be addressed in that manner. The 'normal' V4 processing of the rec file gets us back to the right words, and then the hybrid extra block appended provides additional information on how far to skip ahead inside the subwork done on the word or set of words, so that prior completed work is not replicated.

The restore_tester_fmt is great for determining exactly what was processed, written to .pot files, etc. So that we know 100% that we restart at proper location, not before, and CERTAINLY not later in the word stream.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with restore_tester_fmt.c and use it to examine restart behavior for the listed rules, rexgen, multi-salt, single, markov, mask, and wordlist-mask modes. Compare the processed and recorded work across the relevant .rec and .pot files. Done means each mode resumes at the proper location without repeating or skipping word-stream work.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
cli, testing
Issue type
Bug
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.