openwall / openwall/john

Store progress with decimals instead of just an integer in .rec file

Open
#1,875 3 comments 0 reactions 1 assignee View on GitHub

@frank-dittrich is already working on this.

Since Mar 18, 2016.

core branch enhancement
Dominant language
C
Stars
13.6k
Forks
2.6k
PR merge metrics
No merged PRs in 30d

Description

This probably requires bumping the rec file format version (RECOVERY_V in params.h), so it needs to be coordinated with master. And this change alone most likely isn't a good enough reason to bump the .rec file version. So may be we should keep this in mind when the version needs to be bumped anyway.

The struct status_main definition in status.h would also need to be adjusted.

Currently, when running ./john --status, the two decimals of the reported progress will always be 00.
Would be nice to get the same level of detail you get when pressing any key or with kill -s USR1 <pid>.

Worth discussing on john-dev?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.