openwall / openwall/john

Add Unicode support to MASK mode

Open
#1,629 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement non-trivial
Dominant language
C
Stars
13.6k
Forks
2.6k
PR merge metrics
No merged PRs in 30d

Description

I have not thought this one through fully, but it was seen during contest that Mask mode had some limitations when it comes to utf8. Possibly it can handle things better, and only needs proper documentation, but I would bet that support of multi-byte is simply not there.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the MASK mode implementation and its handling of UTF-8 or multi-byte input. Check whether the limitation is in support or documentation, then identify the relevant tests or reproduce the contest case. Done means the intended Unicode behavior is documented and verified, or the missing support is clearly scoped.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
security
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.