openwall / openwall/john

Add Unicode support to rules

Open
#1,628 10 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement non-trivial
Dominant language
C
Stars
13.6k
Forks
2.6k
PR merge metrics
No merged PRs in 30d

Description

This one will also likely sit a while, but lets get it documented here.

We may want to completely replicate the rules engine for utf-8 (or possibly compile it twice, like we do for dynamic_big_crypt), because it is very likely that adding MBCS to rules will greatly slow it down overall.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the rules engine and the existing dynamic_big_crypt implementation mentioned in the issue. Determine the intended Unicode or UTF-8 scope and compare the performance implications of the proposed approaches. Done requires an agreed implementation direction and documented behavior and performance expectations.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
security
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.