openwall / openwall/john

Add Unicode support to incremental

Open
#1,627 12 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement new tool non-trivial
Dominant language
C
Stars
13.6k
Forks
2.6k
PR merge metrics
No merged PRs in 30d

Description

I know this one will sit a long while (likely), but lets get these documented as wish list items.

Btw, incremental 'does' work in a limited subset for utf-8. It can handle 2 and 3 char utf8 pretty well, but it does not know anything about the encoding system. It simply works because of internal tri-glyph logic. So those 3 (or 2) bytes of utf-8 get seen as a very often used 3 (or 2) character substring and thus become very highly likely to be output. But that does not mean inc does utf-8.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue names incremental but no source files, tests, or entry point. Start by locating the incremental implementation and determining how its current limited UTF-8 behavior differs from encoding-aware support; completion criteria would need to be defined before implementation.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
cli
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.