openwall / openwall/john

If errors in config making fmt_extern.h fmt_registers.h then we should fail configure

Open
#1,590 15 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
C
Stars
13.6k
Forks
2.6k
PR merge metrics
No merged PRs in 30d

Description

The creation of these files should also be moved before creation of the Makefiles, and abort the configure, so that we do not leave the system in a state that can not be built from.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the configure flow that creates fmt_extern.h and fmt_registers.h, then inspect when the Makefiles are generated. The change is done when failures creating either header abort configure before Makefiles are created, leaving no partially configured state that cannot be built.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
build-system
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.