Siemens S7, stop running around in circles.
Open
Nobody has claimed this yet.
enhancement
- Dominant language
- C
- Stars
- 13.6k
- Forks
- 2.6k
- PR merge metrics
- No merged PRs in 30d
Description
We've been too quick to make uneducated hacks in the Siemens S7 format lately. I have the feeling the current canonicalization (change *0* to *1*) is somewhat flawed. We should probably strip that field altogether in the canonical .pot representation.
BUT my bottom line is we should sort it out before we do anything now.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No files, tests, or entry points are named. Start by locating the Siemens S7 format handling and the canonical .pot representation, then review the existing *0* to *1* canonicalization. Work is not ready until the intended canonical form and validation criteria are agreed.
Written by the indexing model from the issue text.
Assessment
- Domain
- security
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 20/100