openvinotoolkit / openvinotoolkit/docker_ci

openvino dockerfile build

Open
#291 0 comments 0 reactions 2 assignees View on GitHub

@artanokhov is already working on this.

Since Oct 19, 2023.

Dominant language
Python
Stars
70
Forks
65
Avg merge
16h 59m
Merged PRs (30d)
3

Description

The dockerfile is very great.
https://github.com/openvinotoolkit/docker_ci/blob/master/dockerfiles/ubuntu18/build_custom/Dockerfile

Start from line 79.
1.
Why don't you use the dockerfile.fix method to build the docker image?
Are the dockerfile.original and dockerfile.fix same step to build docker image?
2.
What is the advantage of the dockerfile.original method (a chain of FROM xxx AS xxx)?

dockerfile.original

FROM ubuntu:18.04 AS copy_openvino
RUN cmd  (copy_openvino) ...

FROM copy_openvino AS openvino
RUN cmd  (openvino) ...

FROM openvino AS opencv
RUN cmd  (opencv) ...

FROM opencv as openvino_repo
RUN cmd  (openvino_repo) ...

dockerfile.fix
comment the redundant FROM xxx AS xxx

FROM ubuntu:18.04 AS copy_openvino
RUN cmd  (copy_openvino) ...

# FROM copy_openvino AS openvino
RUN cmd  (openvino) ...

# FROM openvino AS opencv
RUN cmd  (opencv) ...

# FROM opencv as openvino_repo
RUN cmd  (openvino_repo) ...

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.