openui / openui/open-ui

[Breadcrumb] Should our default anatomy include hidden list elements?

Open
#201 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

breadcrumb needs-champion needs-triage
Dominant language
MDX
Stars
4.5k
Forks
226
Avg merge
2d 22h
Merged PRs (30d)
4

Description

Carrying my comment on the default proposed anatomy including list items as aria-hidden for something which seems to always be presentational only.

If the expectation is that a separator (or divider) slotted in as part of a list item is presentational only - therefore, always hidden, why make that the rule? It seems more intuitive to expect that we have a presentational recommendation with this as "allowable". Either way, I think we need a caveat that this can be handled a couple of ways (per @assuncaocharles's comment elsewhere in the spec).

It may just be myself, but I prefer verbosity on some of these things when we're providing a recommendation or "blessed" implementation.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the Breadcrumb default anatomy proposal and the referenced discussion about separators, list items, and aria-hidden. Determine whether the recommendation should require hidden list elements or describe this as an allowable approach, then update the specification once the expected behavior is decided.

Written by the indexing model from the issue text.

Assessment

Domain
accessibility
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
15/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.