openui / openui/open-ui

[focusgroupV2] Bikeshed names for the focusgroup itemcontrols modifiers

Open
#1,489 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

focusgroup
Dominant language
MDX
Stars
4.5k
Forks
226
Avg merge
2d 22h
Merged PRs (30d)
4

Description

Focusgroup V2 proposes itemcontrols, with noitemcontrols as its negative counterpart. Review feedback on PR #1488 noted that itemcontrols does not clearly communicate its purpose, on which I agree.

With itemcontrols, focusable controls with focusgroup="none" that descend from any non-active focusgroup item are not considered for sequential focus navigation.

<div focusgroup="toolbar itemcontrols" aria-label="Documents">
  <span tabindex="0">
    Quarterly report
    <button focusgroup="none">Rename</button>
    <button focusgroup="none">Delete</button>
  </span>

  <span tabindex="0">
    Project plan
    <button focusgroup="none">Rename</button>
    <button focusgroup="none">Delete</button>
  </span>
</div>

<button>Upload document</button>
  • If focus is on Quarterly report and the user presses Tab, focus moves to its Rename button.
  • Pressing Tab again moves focus to its Delete button.
  • Pressing Tab again skips the inactive Project plan item and its controls, moving focus to Upload document.
  • Directional navigation moves between Quarterly report and Project plan (no change from a focusgroup without this modifier).
  • If focus moves to Project plan, its controls become the available through sequential focus navigation.
  • Pressing Shift+Tab from "Upload document" restores the previously focused focusgroup item, skipping over any nested controls, as they are only considered "active" when focus is on or within them.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Read the Focusgroup V2 proposal and the review feedback on PR #1488, then compare the proposed itemcontrols and noitemcontrols behavior with clearer naming options. Done means reaching agreement on names that communicate the sequential and directional focus-navigation behavior described in this issue.

Written by the indexing model from the issue text.

Assessment

Tech stack
html
Domain
accessibility, frontend
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Quiet
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.