openui / openui/open-ui

[menu] define orientation attribute

Open
#1,201 7 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

menu needs edits needs-triage toolbar
Dominant language
MDX
Stars
4.5k
Forks
226
Avg merge
2d 22h
Merged PRs (30d)
4

Description

In the case of menubars the default will be horizontal but it's possible people will want vertical ones. This orientation attribute should control which arrow keys are used for navigation as well as setting the aria-orientation value. It should probably also apply some default styles to actually make the menubar render vertical.

MDN suggests you'd also want this for menulist with a default of vertical, I'm not sure if this is actually useful for menulist and what the rendering would look like but for the sake of completeness it seems reasonable to support both.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the issue's menubar and menulist requirements and compare the proposed behavior with the MDN guidance mentioned. Define how orientation affects arrow-key navigation, aria-orientation, and default vertical rendering, including whether menulist support is useful. Done means the behavior and defaults are specified for both components.

Written by the indexing model from the issue text.

Assessment

Domain
accessibility
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.