openui / openui/open-ui

[openable] how should we support find in page?

Open
#1,162 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

needs-triage openable
Dominant language
MDX
Stars
4.5k
Forks
226
Avg merge
2d 22h
Merged PRs (30d)
4

Description

Currently the openable explainer plans to use hidden=until-found attribute value pair with some special handling such that openables can be searchable.

Is this the correct choice?

The proposed UA styles were potentially naive based on how complex the hidden=until-found styling is in chrome.

  1. Hidden attribute isn't implemented purely in UA stylesheet, as such the styles have a higher specificity than if they were, this means that my proposed styles won't actually work. In my prototype I had to use !important which is undesirable.

  2. I used revert but that probably isn't the correct value for a UA style.

Given this complexity is it better off being a different mechanism such as openable=searchable? Would this have essentially the same issues given we'd probably share code between the two mechanisms?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the openable explainer's “find-in-page support” and “rendering” sections, then review the stated concerns about hidden=until-found, UA stylesheet specificity, !important, and revert. Done means reaching and documenting a decision on whether the proposed mechanism and styles are correct or whether an alternative such as openable=searchable should be used.

Written by the indexing model from the issue text.

Assessment

Tech stack
html
Domain
frontend
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.