openui / openui/open-ui

[invokers / popovers] stopping a video in a popover

Open
#1,107 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

command-invokers needs-triage popover
Dominant language
MDX
Stars
4.5k
Forks
226
Avg merge
2d 22h
Merged PRs (30d)
4

Description

Recently at a conference someone came with a question to me.

When a video is playing and a popover gets closed, you still hear the video in the background (so it isn't stopped)
This results in an unwanted behaviour in most cases.

I was wondering what would happen when combining popovertarget and commandfor in this case:
Here is a quick codepen link

And (quite understandably as previously discussed) a commandfor takes precedence over the popovertarget.
I understand this as we want popovers to work with invokers as well, but my question is rather about the use case than the "hack" I was trying to pull in that demo.

So a few questions I want to ask, just to make sure we don't forget:

Shouldn't there be a way to kill items playing inside of a popover without the use of JavaScript?
Can we maybe revisit this with invokers?
Is there any way that a video still playing when a popover is closed is a wanted behaviour?
(And when this happens, isn't that just bad A11Y as well, i wonder?)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the linked CodePen and the issue's questions about popovertarget, commandfor, and video playback. Determine whether a declarative behavior for stopping media in a closed popover should be specified, and document the accessibility implications and expected interaction.

Written by the indexing model from the issue text.

Assessment

Tech stack
html
Domain
accessibility, frontend, web-dev
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.