opentracing-contrib / opentracing-contrib/java-spring-cloud

RFC: Should spans be reported for websocket client connections

Open
#58 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Java
Stars
399
Forks
143
Avg merge
1d 3h
Merged PRs (30d)
22

Description

When instrumenting a service using websockets, it also reports spans for the HTTP communications to establish the inbound and outbound connections: https://github.com/opentracing-contrib/java-spring-cloud/pull/53#issuecomment-331924207

Options:

  • Leave as is, and use this information to know when and how many connections are being made. If so - might be good to see if websocket message spans can be correlated to the session connection spans in some way
  • Automatically register skip patterns for the inbound/outbound path prefixes

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No files or tests are named. Start by reviewing the linked pull request comment and the two proposed options, then identify the websocket instrumentation entry points and existing span tests. Done means reaching a decision and documenting or implementing the chosen behavior, including how connection and message spans should relate if applicable.

Written by the indexing model from the issue text.

Assessment

Tech stack
java, spring-boot
Domain
observability-sre
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.