opentracing-contrib / opentracing-contrib/java-spring-cloud
`uber-trace-id` from incoming request overwrites client span in spring cloud gateway tracing
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 399
- Forks
- 143
- Avg merge
- 1d 3h
- Merged PRs (30d)
- 22
Description
Client span is generated here:
Next we try to inject this span into Http Headers of inner request:
But if the incoming request to Spring Cloud Gateway had it own uber-trace-id header this will overwrite what we just tried to do. Is it a bug?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with TraceRequestHttpHeadersFilter.java, especially the client-span creation around lines 55-60 and header injection around lines 65-70. Trace how an existing incoming uber-trace-id is handled, then look for the gateway starter's relevant tests; done should include coverage showing the generated client span is preserved when that header is already present.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java, spring, spring-boot
- Domain
- backend, observability-sre
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100