opentracing-contrib / opentracing-contrib/java-spring-cloud
`opentracing-spring-cloud-redis-starter` RedisClusterConnection wrapped in TracingRedisConnection
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 399
- Forks
- 143
- Avg merge
- 1d 3h
- Merged PRs (30d)
- 22
Description
The Redis aspect will wrap all RedisConnection objects returned by the intercepted call in TracingRedisConnection, although Jedis (not sure if Lettuce too) can return RedisClusterConnection from the getConnection call which should be wrapped as TracingRedisClusterConnection.
In spring, using the actuator, this leads to issues with for instance the Redis health indicator that behaves differently for clustered and non-clustered modes.
See this repository for an example: https://github.com/bivab/opentracing-spring-cloud-redis-starter-demo
Including or excluding opentracing-spring-cloud-redis-starter in pom.xml will lead to different results.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with instrument-starters/opentracing-spring-cloud-redis-starter/src/main/java/io/opentracing/contrib/spring/cloud/redis/RedisAspect.java and inspect the connection wrapping at the linked location. Use the demo repository and its pom.xml to reproduce the difference with the starter included, then verify that clustered connections preserve the Redis health indicator behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java, redis, spring, spring-boot
- Domain
- backend, databases
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100