opentracing-contrib / opentracing-contrib/java-spring-cloud

Using OT side-by-side with NewRelic

Open
#327 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Java
Stars
399
Forks
143
Avg merge
1d 3h
Merged PRs (30d)
22

Description

We are using NewRelic for APM management. And we want to use our own distributed tracing based on OT alongside with NewRelic. Doing this I came up on problem - NewRelic is not capturing details of SQL transactions when OT JDBC instrumentation is enabled.

Investigating the issue I found this commit: https://github.com/opentracing-contrib/java-spring-cloud/pull/277
It seems like at some moment dynamic proxies where introduced instead of plain wrappers.

Is there some specific reason for using dynamic proxies over plain wrappers? Can we roll back to wrappers or, at least, make this configurable? I am ready to offer the patch.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the dynamic-proxy change in java-spring-cloud pull request #277 and the OT JDBC instrumentation behavior described in the issue. Determine why NewRelic no longer captures SQL transaction details, then verify that the chosen wrapper or configuration approach preserves OT tracing while restoring those details.

Written by the indexing model from the issue text.

Assessment

Tech stack
java, spring-boot
Domain
backend, observability-sre
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.