opentracing-contrib / opentracing-contrib/java-spring-cloud

DefaultAsyncAutoConfiguration override a implicit AsyncTaskExecutor

Open
#313 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Java
Stars
399
Forks
143
Avg merge
1d 3h
Merged PRs (30d)
22

Description

problem

spring-aop has a implicit rule for determining default AsyncExecutor when there`s no AsyncConfigurer existed

See AsyncExecutionAspectSupport.java#L227

DefaultAsyncAutoConfiguration will override it in the above case


@Configuration
@ConditionalOnMissingBean(AsyncConfigurer.class)
  static class DefaultTracedAsyncConfigurerSupport extends AsyncConfigurerSupport {
    @Autowired
    @Lazy
    private Tracer tracer;
    @Override
    public Executor getAsyncExecutor() {
      return new TracedExecutor(new SimpleAsyncTaskExecutor(), tracer);
    }
  }
version

java version "1.8.0_131"
spring-aop 4.3.11
opentracing-spring-cloud-core latest

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with AsyncExecutionAspectSupport.java at the linked line, then inspect DefaultAsyncAutoConfiguration and its DefaultTracedAsyncConfigurerSupport configuration. Reproduce the case with spring-aop 4.3.11 and opentracing-spring-cloud-core, and verify that the framework's implicit AsyncTaskExecutor selection is preserved when no AsyncConfigurer exists.

Written by the indexing model from the issue text.

Assessment

Tech stack
java, spring-boot
Domain
backend, observability
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.