opentracing-contrib / opentracing-contrib/java-spring-cloud
Application doesn't startup in Spring Messaging 5.3.2
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 399
- Forks
- 143
- Avg merge
- 1d 3h
- Merged PRs (30d)
- 22
Description
Description
In opentracing-spring-cloud-websocket-starter WebsocketAutoConfiguration calls a method that suffers a break change in Spring Messaging 5.3.2
WebsocketAutoConfiguration
https://github.com/opentracing-contrib/java-spring-cloud/blob/master/instrument-starters/opentracing-spring-cloud-websocket-starter/src/main/java/io/opentracing/contrib/spring/cloud/websocket/WebsocketAutoConfiguration.java#L45- Method changed
- https://github.com/spring-projects/spring-framework/blame/master/spring-messaging/src/main/java/org/springframework/messaging/simp/config/AbstractMessageBrokerConfiguration.java#L151-L152
- Commit: https://github.com/spring-projects/spring-framework/commit/017242463502f451c6c71a823b9c5232276dd78e#diff-a38442140d6b74b2bda6a51e016b013201c2c198e6f95000798420274b7e2282L150-R152
Log
***************************
APPLICATION FAILED TO START
***************************
Description:
An attempt was made to call a method that does not exist. The attempt was made from the following location:
io.opentracing.contrib.spring.cloud.websocket.WebsocketAutoConfiguration.tracingInboundChannelInterceptor(WebsocketAutoConfiguration.java:45)
The following method did not exist:
'org.springframework.messaging.support.AbstractSubscribableChannel org.springframework.web.socket.config.annotation.WebSocketMessageBrokerConfigurationSupport.clientInboundChannel()'
The method's class, org.springframework.web.socket.config.annotation.WebSocketMessageBrokerConfigurationSupport, is available from the following locations:
jar:file:[...]/.gradle/caches/modules-2/files-2.1/org.springframework/spring-websocket/5.3.2/7a0e2a689c3dbbb084b59cd7188d37164488af31/spring-websocket-5.3.2.jar!/org/springframework/web/socket/config/annotation/WebSocketMessageBrokerConfigurationSupport.class
The class hierarchy was loaded from the following locations:
org.springframework.web.socket.config.annotation.WebSocketMessageBrokerConfigurationSupport: file:[...]/.gradle/caches/modules-2/files-2.1/org.springframework/spring-websocket/5.3.2/7a0e2a689c3dbbb084b59cd7188d37164488af31/spring-websocket-5.3.2.jar
org.springframework.messaging.simp.config.AbstractMessageBrokerConfiguration: file:[...]/.gradle/caches/modules-2/files-2.1/org.springframework/spring-messaging/5.3.2/d4b189cd434be6790128f4b4397998c655cfecea/spring-messaging-5.3.2.jar
Action:
Correct the classpath of your application so that it contains a single, compatible version of org.springframework.web.socket.config.annotation.WebSocketMessageBrokerConfigurationSupport
Process finished with exit code 0
"Solution"
I disabled this configuration :(
@EnableAutoConfiguration(exclude=[WebsocketAutoConfiguration::class])
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with instrument-starters/opentracing-spring-cloud-websocket-starter/src/main/java/io/opentracing/contrib/spring/cloud/websocket/WebsocketAutoConfiguration.java at line 45, then compare the referenced Spring Messaging 5.3.2 method change. Reproduce the startup failure with Spring Messaging 5.3.2 and verify that the websocket auto-configuration starts successfully without excluding WebsocketAutoConfiguration.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java, spring, spring-boot
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100