opentracing-contrib / opentracing-contrib/java-spring-cloud

TracedExecutorService is always configured with traceWithActiveSpanOnly=true

Open
#293 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Java
Stars
399
Forks
143
Avg merge
1d 3h
Merged PRs (30d)
22

Description

ExecutorBeanPostProcessor is always wrapping ExecutorServices with TracedExecutorService which has traceWithActiveSpanOnly property set by default to true.

   public TracedExecutorService(ExecutorService delegate, Tracer tracer) {
      this(delegate, tracer, true);
   }

This is something which should be accessible by some property i guess.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Search for ExecutorBeanPostProcessor and TracedExecutorService, starting with the constructor that defaults traceWithActiveSpanOnly to true. Inspect how related tracing settings are configured in the project; the work is done when this behavior is exposed as a configuration property and the configured value is honored.

Written by the indexing model from the issue text.

Assessment

Tech stack
java, spring, spring-boot
Domain
backend, observability
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.