opentracing-contrib / opentracing-contrib/java-spring-cloud

Can't send JMS messages, getting 'uber-trace-id' is not a valid java identifier.

Open
#234 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Java
Stars
399
Forks
143
Avg merge
1d 3h
Merged PRs (30d)
22

Description

Using spring-integration and after added the opentracing starter:

        <dependency>
            <groupId>io.opentracing.contrib</groupId>
            <artifactId>opentracing-spring-jaeger-cloud-starter</artifactId>
            <version>1.0.3</version>
        </dependency>
        <dependency>
            <groupId>io.opentracing.contrib</groupId>
            <artifactId>opentracing-spring-cloud-starter</artifactId>
            <version>0.2.4</version>
        </dependency>

started to get errors:

javax.jms.JMSRuntimeException: AMQ139012: The property name 'uber-trace-id' is not a valid java identifier.
	at org.apache.activemq.artemis.jms.client.ActiveMQMessage.checkProperty(ActiveMQMessage.java:992) ~[artemis-jms-client-2.6.4.jar:2.6.4]
	at org.apache.activemq.artemis.jms.client.ActiveMQMessage.setObjectProperty(ActiveMQMessage.java:763) ~[artemis-jms-client-2.6.4.jar:2.6.4]
...

Accordingly to this (see at the bottom) all dashes should be replaced with $dash$ but this is not happening. When I try to use raw opentracing java-jms it works as expected

I created repo that can be used to reproduce this issue

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the failure with the repository linked in the issue and compare the Spring Cloud starter's JMS behavior with raw opentracing-java-jms, using the reported dependencies and Artemis stack trace as the entry point. Done means JMS messages can be sent and the uber-trace-id property is encoded as documented instead of being rejected as an invalid Java identifier.

Written by the indexing model from the issue text.

Assessment

Tech stack
java, spring-boot
Domain
backend, distributed-systems
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.