opentracing-contrib / opentracing-contrib/java-spring-cloud
Library silently enables Async
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 399
- Forks
- 143
- Avg merge
- 1d 3h
- Merged PRs (30d)
- 22
Description
The configuration class DefaultAsyncAutoConfiguration enables @Async by using @EnableAsync. Is this a good pattern? I didn't expected that the library for instrumenting code is activating this functionality (per default). I would expect that the library set's up a proper configuration but doesn't enable it.
I have stumpled over this issue because we deactivated @Async for one environment and the application failed because reference threadpools have not been set-up. Took me some while to figer out what's going wrong.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with DefaultAsyncAutoConfiguration and trace how @EnableAsync is applied, including the behavior when an application deactivates @Async. Check the surrounding configuration and tests, if present. Done means the library's async behavior matches its documented configuration contract and does not unexpectedly break applications that disable @Async.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java, spring, spring-boot
- Domain
- backend, observability
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100