opentracing-contrib / opentracing-contrib/java-spring-cloud
Feign clients created manually doesn't work with feign.Okhttp client
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 399
- Forks
- 143
- Avg merge
- 1d 3h
- Merged PRs (30d)
- 22
Description
Feign clients created manually with Okhttp client doesn't work, I believe it's because Okhttp class is final and the AOP approach doesn't consider final classes. Should be ok to remove this final type validation from the aspect? Or is there another way to make this work with the Okhttp client?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the AOP aspect's final-type validation and the path for manually created Feign clients using the OkHttp client. Reproduce the failure, determine whether removing that validation or another approach is appropriate, and verify that tracing works for the affected client.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java, spring, spring-boot
- Domain
- api, backend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100