hard coded JdbcTracingUtils
Nobody has claimed this yet.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 25/100
Research direction
Start by locating the hard-coded JdbcTracingUtils.on* calls and compare them with the SpanDecorator examples linked in the issue. Clarify how users should customize the span and which decorator API is expected; done means JDBC instrumentation no longer requires fixed tracing behavior and has coverage for the chosen extension pattern.
Written by the indexing model from the issue text.
Description
Most of the other opentracing contrib projects use a SpanDecorator so users can customize the span.
Is there any reason you have hard-coded JdbcTracingUtils.on*() instead of the SpanDecorator pattern?
Examples:
- https://github.com/opentracing-contrib/java-spring-web/blob/master/opentracing-spring-web/src/main/java/io/opentracing/contrib/spring/web/client/RestTemplateSpanDecorator.java
- https://github.com/opentracing-contrib/java-spring-web/blob/master/opentracing-spring-web/src/main/java/io/opentracing/contrib/spring/web/interceptor/HandlerInterceptorSpanDecorator.java
- https://github.com/opentracing-contrib/java-web-servlet-filter/blob/master/opentracing-web-servlet-filter/src/main/java/io/opentracing/contrib/web/servlet/filter/ServletFilterSpanDecorator.java
- https://github.com/opentracing-contrib/java-okhttp/blob/master/opentracing-okhttp3/src/main/java/io/opentracing/contrib/okhttp3/OkHttpClientSpanDecorator.java
- Dominant language
- Java
- Stars
- 86
- Forks
- 53
- Avg merge
- 1d 3h
- Merged PRs (30d)
- 18
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from opentracing-contrib/java-jdbc
-
Dependency Dashboard Open
Difficulty 5/5 Over a week Newbie friendliness 20/100
opentracing-contrib/java-jdbc#130 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 55/100
opentracing-contrib/java-jdbc#125 ·
-
Difficulty 5/5 Over a week Newbie friendliness 15/100
opentracing-contrib/java-jdbc#124 · 1 reaction ·
-
Difficulty 5/5 Over a week Newbie friendliness 25/100
opentracing-contrib/java-jdbc#122 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 25/100
opentracing-contrib/java-jdbc#121 ·
All issues in opentracing-contrib/java-jdbc
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
-
bug needs triage
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
-
Difficulty 1/5 Under an hour Newbie friendliness 94/100
objectionary/hone-maven-plugin#1061 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
spring-projects/spring-modulith#1895 ·