openstreetmap / openstreetmap/mod_tile
Don't use apr_global_mutex to guard storage backend initialisation
Open
@apmon is already working on this.
Since May 23, 2013.
- Dominant language
- C++
- Stars
- 318
- Forks
- 199
- PR merge metrics
- No merged PRs in 30d
Description
Commit 2c538916be4f8dff28181ea5a47d65d84b4b2a03 introduced locking around memory allocation for an array containing pointers to the storage backends, as apache's memory pool functions aren't thread safe. It used apr_global_mutex, but I think apr_global_mutex not only synchronizes between threads, but also between process which isn't necessary for the storage backend memory allocation. Instead presumably apr_thread_mutex is what we want.
I need to verify this before committing the change, hence this reminder ticket.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.