openstreetmap / openstreetmap/iD

When adding Turn Restrictions, split the from and to ways near the intersection

Open
#5,000 6 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

field
Dominant language
JavaScript
Stars
3.9k
Forks
1.5k
Avg merge
5d 3h
Merged PRs (30d)
44

Description

This is a request from several teams working with turn restrictions (including Mapbox and others). It would be useful to split turn restriction from/to ways near the turn restriction intersection.

split_at_junctions

The benefits here include:

  • limit the extent of the effects of the turn restriction
  • better review of turn restrictions in tools like on OSM or OSMCha or JOSM
  • avoid unnecessary modification of the turn restriction (e.g. a "new" TR may end up with version 2 just because a split happened far away after it was added).

For example:

It's pretty easy to tell what was changed here because the turn restriction is scoped tightly to the intersection:
screenshot 2018-04-19 09 57 39

Not so much for this one, which covers a large portion of Detroit:
screenshot 2018-04-19 09 58 20

(Both changes were made with iD - the first example just happened to involve ways that were already split around there).

cc @maning @planemad

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue names no files, tests, or entry points. Review iD’s current turn-restriction editing flow against the screenshots and stated benefits, then determine the required behavior and scope. Done should mean that adding a restriction splits its from and to ways near the intersection and keeps the restriction tightly scoped.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
web-dev
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.