openssl / openssl/openssl

Config .include directive processing for directories is not deterministic

Open
#27,300 8 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

triaged: feature
Dominant language
C
Stars
30.8k
Forks
11.5k
Avg merge
10m
Merged PRs (30d)
1

Description

OpenSSL, processing .include somedir in config, relies on opendir/readdir/closedir API.

They are documented as not thread-safe (we can neglect it, I suppose) and not defining any order of file processing.

I'd consider lack of order on processing .include to be a bug.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Trace the .include somedir handling to the code that calls opendir, readdir, and closedir. Determine how directory entries are currently processed and define a deterministic ordering for them; done means repeated processing of the same directory uses the same file order.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
security
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.