openssl / openssl/openssl

QUIC: dereference NULL pointer in function qtx_reserve_txe()

Open
#23,612 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

branch: 3.3 branch: 3.4 branch: 3.5 branch: 3.6 branch: master triaged: bug
Dominant language
C
Stars
30.8k
Forks
11.5k
Avg merge
10m
Merged PRs (30d)
1

Description

The function ossl_qtx_write_pkt() (ssl/quic/quic_record_tx.c) has a call qtx_reserve_txe(qtx, NULL, txe, qtx->mdpl) on line 827
Call stack
qtx_reserve_txe(qtx, NULL, txe, qtx->mdpl) -> qtx_resize_txe(qtx, NULL, txe, n) -> ossl_list_txe_remove(NULL, txe);
This looks like there will be a dereference NULL in the function ossl_list_txe_remove(txl, txe) where txl equal NULL

Can you please confirm or deny this?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in ssl/quic/quic_record_tx.c at the ossl_qtx_write_pkt() call on line 827, then trace qtx_reserve_txe(), qtx_resize_txe(), and ossl_list_txe_remove(). Confirm whether passing NULL as the txl argument is reachable and valid in this path; done means documenting the finding and, if it is a defect, adding an appropriate regression test and fix.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
networking, security
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.