openssl / openssl/openssl

Misspelled constants in include/openssl/core_names.h

Open
#16,919 6 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

branch: master triaged: bug
Dominant language
C
Stars
30.8k
Forks
11.5k
Avg merge
10m
Merged PRs (30d)
1

Description

The string constants OSSL_DRBG_PARAM_MIN_LENGTH and OSSL_DRBG_PARAM_MAX_LENGTH are misspelled in include/openssl/core_names.h (missing "m")

diff --git a/include/openssl/core_names.h b/include/openssl/core_names.h
index 97c4d65949..b3f5d9ab2d 100644
--- a/include/openssl/core_names.h
+++ b/include/openssl/core_names.h
@@ -219,8 +219,8 @@ extern "C" {
 /* DRBG call back parameters */
 #define OSSL_DRBG_PARAM_ENTROPY_REQUIRED        "entropy_required"
 #define OSSL_DRBG_PARAM_PREDICTION_RESISTANCE   "prediction_resistance"
-#define OSSL_DRBG_PARAM_MIN_LENGTH              "minium_length"
-#define OSSL_DRBG_PARAM_MAX_LENGTH              "maxium_length"
+#define OSSL_DRBG_PARAM_MIN_LENGTH              "minmium_length"
+#define OSSL_DRBG_PARAM_MAX_LENGTH              "maxmium_length"
 #define OSSL_DRBG_PARAM_RANDOM_DATA             "random_data"
 #define OSSL_DRBG_PARAM_SIZE                    "size"

As requested in PR #16712 I've opened this as a separate issue due to compatibility concerns.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with include/openssl/core_names.h and inspect the OSSL_DRBG_PARAM_MIN_LENGTH and OSSL_DRBG_PARAM_MAX_LENGTH definitions. Review the compatibility concerns mentioned in PR #16712 before changing the string values, then verify that the constants use the intended spellings without introducing unrelated changes.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
cryptography
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.