openshift / openshift/windows-machine-config-operator

Service and Endpoints for the node exporters are not correctly configured

Open
#826 39 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

lifecycle/frozen
Dominant language
Go
Stars
52
Forks
77
Avg merge
19h 22m
Merged PRs (30d)
93

Description

The windows node exporter is installed on all windows worker nodes, but the required Service and Endpoint resources are no created at all.
There is a service object created, but it's from type ClusterIP, which in this case won't work.
The Service should be of type 'ExternalName' and the Endpoints should be updated by the operator on every node join/deletion operation.
For instance:

apiVersion: v1
kind: Service
metadata:
 labels:
   name: windows-exporter
 name: windows-exporter
 namespace: openshift-windows-machine-config-operator
spec:
 type: ExternalName
 ports:
   - name: metrics
     port: 9182
     protocol: TCP
     targetPort: 9182
 externalName: nodexporter
---
apiVersion: v1
kind: Endpoints
metadata:
 labels:
   name: windows-exporter
 name: windows-exporter
 namespace: openshift-windows-machine-config-operator
subsets:
 - addresses:
     - ip: 1.1.1.1
       targetRef:
         kind: Node
         name: winmach-q84jj
         uid: ab8028e7-a0ed-4f83-89e5-b577be2231ed
     - ip: 1.1.1.1
       targetRef:
         kind: Node
         name: winmach-t5vgm
         uid: 1b710328-88d5-4142-a78f-dd414705cc19
   ports:
     - name: metrics
       port: 9182
       protocol: TCP

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No files or tests are named. Start by locating the operator code that handles Windows node joins and deletions, then inspect how it currently creates the windows-exporter Service. Done means the Service uses ExternalName and the Endpoints reflect node additions and removals, including the metrics port.

Written by the indexing model from the issue text.

Assessment

Tech stack
go, kubernetes
Domain
infrastructure
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.